Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to HLS Image Media Playlists #3365

Merged
merged 11 commits into from
Jun 2, 2021
Merged

Add support to HLS Image Media Playlists #3365

merged 11 commits into from
Jun 2, 2021

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 23, 2021

Close: #2429

@avelad
Copy link
Member Author

avelad commented Apr 23, 2021

Note: I have yet to add tests.

calvin-smith1
calvin-smith1 approved these changes Apr 25, 2021
View reviewed changes
Copy link

@calvin-smith1 calvin-smith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@avelad avelad marked this pull request as ready for review April 26, 2021 06:48
@avelad
Copy link
Member Author

avelad commented Apr 26, 2021

Ready for review!

@OrenMe
Copy link
Contributor

OrenMe commented Apr 26, 2021

Hi @avelad , is there a sample on how this is expected to be used? we recently added support for image adaptations for Dash and had to do it externally cause there is no model for image tracks, so wondering how this relates to dash, if at all.

@avelad
Copy link
Member Author

avelad commented Apr 26, 2021

@OrenMe
https://github.com/image-media-playlist/spec
https://developer.roku.com/en-gb/docs/developer-program/media-playback/trick-mode/hls-and-dash.md#hls-considerations

@avelad
Copy link
Member Author

avelad commented Apr 26, 2021 •
edited
Loading

@OrenMe the DASH thumbnails support was added: b9b3cc8 (It will be released in 3.1.)

@OrenMe
Copy link
Contributor

OrenMe commented Apr 26, 2021

thanks @avelad !

@avelad avelad mentioned this pull request May 5, 2021
Closed
@avelad
Copy link
Member Author

avelad commented May 14, 2021

@joeyparrish can you review this PR?

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 2a4083b into shaka-project:master Jun 2, 2021
@avelad avelad deleted the hls-thumbnails branch June 3, 2021 05:41
@renovate renovate bot mentioned this pull request Jul 14, 2021
Merged
1 task
@ShivamJoker
Copy link

@avelad I need an example how to use thumbnail, can you please provide one?

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@calvin-smith1 calvin-smith1 calvin-smith1 approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HLS Image Media Playlists
6 participants
@avelad @OrenMe @shaka-bot @ShivamJoker @joeyparrish @calvin-smith1