Pass HDR information when getting decoding info from media capabilities #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilities Given we have hdr information on the variant, then when we are checking for decodingInfo, we should be passing this along to the media capabilities API.
When checking for decodingInfo, if we have hdr information available on the variant video stream, then we should use that value to determine the value of transferFunction passed in the VideoConfiguration object.
joeyparrish
approved these changes
Nov 2, 2021
|
All tests passed! |
|
No problem! Happy to help 😄 |
joeyparrish
pushed a commit
that referenced
this pull request
Jan 5, 2022
Fixes #3729 If the video variant stream contains information about `hdr`, then we now use that to provide a value for `transferFunction`, when constructing the [`VideoConfiguration`](https://w3c.github.io/media-capabilities/#videoconfiguration) object used to get decoding info from media capabilities API. The following applies: ```js switch (video.hdr) { case 'SDR': mediaDecodingConfig.video.transferFunction = 'srgb'; break; case 'PQ': mediaDecodingConfig.video.transferFunction = 'pq'; break; case 'HLG': mediaDecodingConfig.video.transferFunction = 'hlg'; break; } ``` Change-Id: I105d789f47b6ff143b3867516481c41224fa8483
joeyparrish
pushed a commit
that referenced
this pull request
Jan 5, 2022
Fixes #3729 If the video variant stream contains information about `hdr`, then we now use that to provide a value for `transferFunction`, when constructing the [`VideoConfiguration`](https://w3c.github.io/media-capabilities/#videoconfiguration) object used to get decoding info from media capabilities API. The following applies: ```js switch (video.hdr) { case 'SDR': mediaDecodingConfig.video.transferFunction = 'srgb'; break; case 'PQ': mediaDecodingConfig.video.transferFunction = 'pq'; break; case 'HLG': mediaDecodingConfig.video.transferFunction = 'hlg'; break; } ``` Change-Id: I3c6ead081203e2c564e15823629cefc8fd61dd60
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3729
If the video variant stream contains information about
hdr, then we now use that to provide a value fortransferFunction, when constructing theVideoConfigurationobject used to get decoding info from media capabilities API.The following applies:
Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass