Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query parameter encoding #40

Merged
merged 2 commits into from
Mar 27, 2015
Merged

Fix query parameter encoding #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65634d4
Don't decode query parameters when copying it to uri
irock Mar 19, 2015
c3bf78e
Add Oskar Arvidsson to contributors
irock Mar 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@

Google Inc. <*@google.com>
Jason Palmer <[email protected]>
Oskar Arvidsson <[email protected]>
Sanborn Hilland <[email protected]>
1 change: 1 addition & 0 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
Jason Palmer <[email protected]>
Joey Parrish <[email protected]>
Natalie Harris <[email protected]>
Oskar Arvidsson <[email protected]>
Sanborn Hilland <[email protected]>
Timothy Drews <[email protected]>
Vasanth Polipelli <[email protected]>
2 changes: 1 addition & 1 deletion third_party/closure/goog/uri/uri.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ goog.Uri.prototype.resolve = function(relativeUri) {
}

if (overridden) {
absoluteUri.setQueryData(relativeUri.getDecodedQuery());
absoluteUri.setQueryData(relativeUri.getQueryData().clone());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! This bug appears to exist upstream, as well. Can you report and/or patch there, too? https://github.com/google/closure-library/blob/master/closure/goog/uri/uri.js#L335

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes, will do.

} else {
overridden = relativeUri.hasFragment();
}
Expand Down