Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LCEVC integration #4050

Merged
merged 25 commits into from
Oct 3, 2022
Merged

Commits on Jun 29, 2022

  1. Shaka Player - LCEVC Integration

    Integration of MPEG-5 Part-2 LCEVC into Shaka Player workflow as a config option to be enabled and the necessary configurations and elements to be passed through the constructor.
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    30c2008 View commit details
    Browse the repository at this point in the history
  2. Added New Lines to solve Linter errors

    Added new lines in build types to avoid new line errors.
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    701d5c9 View commit details
    Browse the repository at this point in the history
  3. Added Checks to verify if dependencies for LCEVC DIL Libs are satisfied

    When the LCEVC DIL object is setup in player.js we have browser and config specific checks added and additional library based checks in lcevc_dil.js.
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    bc5700e View commit details
    Browse the repository at this point in the history
  4. Fixes for PR Comments

    1. Removed LCEVC as a config option
    2. Created a new type for LCEVC DIl Config under externs.
    3. Documentation Updated.
    4. Typos and Definitions fixed.
    5. Removed code that were not used anymore due to library changes.
    6. Moved SupportStatus and SupportError inside SupportObject.
    7. Created Enum for container format.
    8. Added more descriptions about the config parameters
    9. Changed LCEVC DIL class to implement IReleaseable and renamed close to release.
    Typos Fixed
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    a95f8e7 View commit details
    Browse the repository at this point in the history
  5. Fix for PR - 2

    Added dilConfig type in the documentation.
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    2f0e1c1 View commit details
    Browse the repository at this point in the history
  6. Version Update for LCEVC DIL library

    We have updated the library with some stability fixes and updated the npm version.
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    bced0ed View commit details
    Browse the repository at this point in the history
  7. PR Change Request Fix

    1. Cleaned up the way createMediaSourceEngine is called from player.js with Lcevc
    2. Changed the parameterisation of the resize function in lcevc_dil.js
    3. Moved Typecasting from lcevc_dil.js to player.js
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    0dd90dd View commit details
    Browse the repository at this point in the history
  8. Rebase : Shaka Player - LCEVC Integration

    Integration of MPEG-5 Part-2 LCEVC into Shaka Player workflow as a config option to be enabled and the necessary configurations and elements to be passed through the constructor.
    Rebase
    
    Added New Lines to solve Linter errors
    
    Added new lines in build types to avoid new line errors.
    Added Checks to verify if dependencies for LCEVC DIL Libs are satisfied
    
    When the LCEVC DIL object is setup in player.js we have browser and config specific checks added and additional library based checks in lcevc_dil.js.
    Rebase
    
    Fixes for PR Comments
    
    1. Removed LCEVC as a config option
    2. Created a new type for LCEVC DIl Config under externs.
    3. Documentation Updated.
    4. Typos and Definitions fixed.
    5. Removed code that were not used anymore due to library changes.
    6. Moved SupportStatus and SupportError inside SupportObject.
    7. Created Enum for container format.
    8. Added more descriptions about the config parameters
    9. Changed LCEVC DIL class to implement IReleaseable and renamed close to release.
    Typos Fixed
    
    
    Fix for PR - 2
    
    Added dilConfig type in the documentation.
    
    Version Update for LCEVC DIL library
    
    We have updated the library with some stability fixes and updated the npm version.
    
    PR Change Request Fix
    
    1. Cleaned up the way createMediaSourceEngine is called from player.js with Lcevc
    2. Changed the parameterisation of the resize function in lcevc_dil.js
    3. Moved Typecasting from lcevc_dil.js to player.js
    Rebase
    
    Testing build and testing
    
    Testing build and testing before commit
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    b4e383c View commit details
    Browse the repository at this point in the history
  9. Changed type of argument to accept null

    mediaSourceEngine.updateLcevcDil changed type of argument to accept null for use cases without LCEVC that are causing a type error in closure compiler
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    428b006 View commit details
    Browse the repository at this point in the history
  10. Added updateLcevc in fake_media_source

    Added updateLcevc in fake_media_source for failures in unit tests.
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    fa32c46 View commit details
    Browse the repository at this point in the history
  11. Fixes for PR - Change Requests

    Changed :
    
    1. Removed Codeblocks from lcevc-integration.md.
    2.  Added description for DPS option.
    3.  Removed unnecessary checks for closeDil from player.js.
    4. Changed JSDoc for some functions on lcevc_dil.js.
    5. Fixed indentation issue
    
    Pending :
    Config option for LcevcDil.LcevcDilConfig object to be added in PlayerConfiguration
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    2d3e8ef View commit details
    Browse the repository at this point in the history
  12. Fix for PR Comments

    Major change in the release is deletion of all code that creates canvas in the core and moved the creation of canvas to UI.
    
    1. Creating of canvas is now moved to ui
    2. Added additional commenting
    3. Rectified some inline comments
    4. Rectified the iOS playback check for lcevc.
    5. Added a new check for ts mimetype for edge browser check.
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    ec136ef View commit details
    Browse the repository at this point in the history
  13. Changed the documentation with type

    Changed the documentation with type of name for makeEvent_() which was changed accidentally
    v-nova-vinod committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    155b5b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. PR Comment Fixes

    1. Changed the way canvas is injected to player.js.
    2. Changed config parameter names.
    3. Added new source in Demo for LCEVC contents.
    4. Commented wherever needed.
    5. Removed all unused variables.
    v-nova-vinod committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    213f29f View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2022

  1. Configuration menu
    Copy the full SHA
    fb968ea View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Fix Test Error Missed entry of configurations in source.json

    Entry for the new config parameters were missing in the source.json due to which the tests failed. We have added those.
    v-nova-vinod committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    8d0ea37 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. PR Comment Fixes

    Fixed and comments and documentation as per the review comments.
    v-nova-vinod committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    588c6ab View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. To resolve conflicts

    Updated source.json and en.json to resolve conflicts.
    v-nova-vinod committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    92877e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Configuration menu
    Copy the full SHA
    93d4d37 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38a7f4e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae01056 View commit details
    Browse the repository at this point in the history
  4. Update en-json

    Update `Log Level` text in the description.
    vinod-balakrishnan authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    3183408 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Updated en.json with source.json text

    Updated en.json with source.json text to match the text and arranged it alphabetically.
    v-nova-vinod committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    931057a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Configuration menu
    Copy the full SHA
    7a86ddb View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Configuration menu
    Copy the full SHA
    3cb53ee View commit details
    Browse the repository at this point in the history