-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LCEVC integration #4050
feat: LCEVC integration #4050
Commits on Jun 29, 2022
-
Shaka Player - LCEVC Integration
Integration of MPEG-5 Part-2 LCEVC into Shaka Player workflow as a config option to be enabled and the necessary configurations and elements to be passed through the constructor.
Configuration menu - View commit details
-
Copy full SHA for 30c2008 - Browse repository at this point
Copy the full SHA 30c2008View commit details -
Added New Lines to solve Linter errors
Added new lines in build types to avoid new line errors.
Configuration menu - View commit details
-
Copy full SHA for 701d5c9 - Browse repository at this point
Copy the full SHA 701d5c9View commit details -
Added Checks to verify if dependencies for LCEVC DIL Libs are satisfied
When the LCEVC DIL object is setup in player.js we have browser and config specific checks added and additional library based checks in lcevc_dil.js.
Configuration menu - View commit details
-
Copy full SHA for bc5700e - Browse repository at this point
Copy the full SHA bc5700eView commit details -
1. Removed LCEVC as a config option 2. Created a new type for LCEVC DIl Config under externs. 3. Documentation Updated. 4. Typos and Definitions fixed. 5. Removed code that were not used anymore due to library changes. 6. Moved SupportStatus and SupportError inside SupportObject. 7. Created Enum for container format. 8. Added more descriptions about the config parameters 9. Changed LCEVC DIL class to implement IReleaseable and renamed close to release. Typos Fixed
Configuration menu - View commit details
-
Copy full SHA for a95f8e7 - Browse repository at this point
Copy the full SHA a95f8e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f0e1c1 - Browse repository at this point
Copy the full SHA 2f0e1c1View commit details -
Version Update for LCEVC DIL library
We have updated the library with some stability fixes and updated the npm version.
Configuration menu - View commit details
-
Copy full SHA for bced0ed - Browse repository at this point
Copy the full SHA bced0edView commit details -
1. Cleaned up the way createMediaSourceEngine is called from player.js with Lcevc 2. Changed the parameterisation of the resize function in lcevc_dil.js 3. Moved Typecasting from lcevc_dil.js to player.js
Configuration menu - View commit details
-
Copy full SHA for 0dd90dd - Browse repository at this point
Copy the full SHA 0dd90ddView commit details -
Rebase : Shaka Player - LCEVC Integration
Integration of MPEG-5 Part-2 LCEVC into Shaka Player workflow as a config option to be enabled and the necessary configurations and elements to be passed through the constructor. Rebase Added New Lines to solve Linter errors Added new lines in build types to avoid new line errors. Added Checks to verify if dependencies for LCEVC DIL Libs are satisfied When the LCEVC DIL object is setup in player.js we have browser and config specific checks added and additional library based checks in lcevc_dil.js. Rebase Fixes for PR Comments 1. Removed LCEVC as a config option 2. Created a new type for LCEVC DIl Config under externs. 3. Documentation Updated. 4. Typos and Definitions fixed. 5. Removed code that were not used anymore due to library changes. 6. Moved SupportStatus and SupportError inside SupportObject. 7. Created Enum for container format. 8. Added more descriptions about the config parameters 9. Changed LCEVC DIL class to implement IReleaseable and renamed close to release. Typos Fixed Fix for PR - 2 Added dilConfig type in the documentation. Version Update for LCEVC DIL library We have updated the library with some stability fixes and updated the npm version. PR Change Request Fix 1. Cleaned up the way createMediaSourceEngine is called from player.js with Lcevc 2. Changed the parameterisation of the resize function in lcevc_dil.js 3. Moved Typecasting from lcevc_dil.js to player.js Rebase Testing build and testing Testing build and testing before commit
Configuration menu - View commit details
-
Copy full SHA for b4e383c - Browse repository at this point
Copy the full SHA b4e383cView commit details -
Changed type of argument to accept null
mediaSourceEngine.updateLcevcDil changed type of argument to accept null for use cases without LCEVC that are causing a type error in closure compiler
Configuration menu - View commit details
-
Copy full SHA for 428b006 - Browse repository at this point
Copy the full SHA 428b006View commit details -
Added updateLcevc in fake_media_source
Added updateLcevc in fake_media_source for failures in unit tests.
Configuration menu - View commit details
-
Copy full SHA for fa32c46 - Browse repository at this point
Copy the full SHA fa32c46View commit details -
Fixes for PR - Change Requests
Changed : 1. Removed Codeblocks from lcevc-integration.md. 2. Added description for DPS option. 3. Removed unnecessary checks for closeDil from player.js. 4. Changed JSDoc for some functions on lcevc_dil.js. 5. Fixed indentation issue Pending : Config option for LcevcDil.LcevcDilConfig object to be added in PlayerConfiguration
Configuration menu - View commit details
-
Copy full SHA for 2d3e8ef - Browse repository at this point
Copy the full SHA 2d3e8efView commit details -
Major change in the release is deletion of all code that creates canvas in the core and moved the creation of canvas to UI. 1. Creating of canvas is now moved to ui 2. Added additional commenting 3. Rectified some inline comments 4. Rectified the iOS playback check for lcevc. 5. Added a new check for ts mimetype for edge browser check.
Configuration menu - View commit details
-
Copy full SHA for ec136ef - Browse repository at this point
Copy the full SHA ec136efView commit details -
Changed the documentation with type
Changed the documentation with type of name for makeEvent_() which was changed accidentally
Configuration menu - View commit details
-
Copy full SHA for 155b5b3 - Browse repository at this point
Copy the full SHA 155b5b3View commit details
Commits on Jul 27, 2022
-
1. Changed the way canvas is injected to player.js. 2. Changed config parameter names. 3. Added new source in Demo for LCEVC contents. 4. Commented wherever needed. 5. Removed all unused variables.
Configuration menu - View commit details
-
Copy full SHA for 213f29f - Browse repository at this point
Copy the full SHA 213f29fView commit details
Commits on Jul 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fb968ea - Browse repository at this point
Copy the full SHA fb968eaView commit details
Commits on Aug 1, 2022
-
Fix Test Error Missed entry of configurations in source.json
Entry for the new config parameters were missing in the source.json due to which the tests failed. We have added those.
Configuration menu - View commit details
-
Copy full SHA for 8d0ea37 - Browse repository at this point
Copy the full SHA 8d0ea37View commit details
Commits on Aug 29, 2022
-
Fixed and comments and documentation as per the review comments.
Configuration menu - View commit details
-
Copy full SHA for 588c6ab - Browse repository at this point
Copy the full SHA 588c6abView commit details
Commits on Sep 1, 2022
-
Updated source.json and en.json to resolve conflicts.
Configuration menu - View commit details
-
Copy full SHA for 92877e8 - Browse repository at this point
Copy the full SHA 92877e8View commit details
Commits on Sep 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 93d4d37 - Browse repository at this point
Copy the full SHA 93d4d37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38a7f4e - Browse repository at this point
Copy the full SHA 38a7f4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae01056 - Browse repository at this point
Copy the full SHA ae01056View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3183408 - Browse repository at this point
Copy the full SHA 3183408View commit details
Commits on Sep 13, 2022
-
Updated en.json with source.json text
Updated en.json with source.json text to match the text and arranged it alphabetically.
Configuration menu - View commit details
-
Copy full SHA for 931057a - Browse repository at this point
Copy the full SHA 931057aView commit details
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7a86ddb - Browse repository at this point
Copy the full SHA 7a86ddbView commit details
Commits on Oct 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3cb53ee - Browse repository at this point
Copy the full SHA 3cb53eeView commit details