fix(hls): Support playing media playlists directly #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested changes
Mar 30, 2022
demo/custom.js
Outdated
| * @return {!Element} div | ||
| * @private | ||
| */ | ||
| makeAssetDialogContentsMediaPlaylist_(assetInProgress, inputsToCheck) { |
There was a problem hiding this comment.
I'm concerned that this extra tab may make the dialog too crowded. (I haven't cherry-picked this to look at the layout yet.)
There was a problem hiding this comment.
After discussing this in person, we decided to keep the separate tab but rename it to be a more general-purpose "HLS" tab.
externs/shaka/player.js
Outdated
| * directly. | ||
| * You can use the <code>shaka.util.MimeUtils.getFullType()</code> utility to | ||
| * format this value. | ||
| * <i>Defaults to <code>'video/mp4; codecs="avc1.42E01E"'</code>.</i> |
There was a problem hiding this comment.
I think we should assume muxed content with AAC audio by default. (Add ", mp4a.40.2")
There was a problem hiding this comment.
most of the content is TS, I think that the default should be TS instead of MP4
lib/hls/hls_parser.js
Outdated
| // Parsing a media playlist results in a single-variant stream. | ||
| if (playlist.type == shaka.hls.PlaylistType.MEDIA) { | ||
| // Get necessary info for this stream, from the config. These are things | ||
| // we would normally be finding from the master playlist (e.g. from values |
- Fixed typos. - Improved description in externs. - Added audio to default media playlist codecs. - Renamed some demo strings.
theodab
force-pushed
the
mediaPlaylistBranch
branch
from
7ee8248
to
61c0e50
Compare
joeyparrish
previously approved these changes
Mar 30, 2022
|
You have a new test that needs to be updated with the new default codec string. Looks good otherwise, though. |
joeyparrish
approved these changes
Mar 31, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3536