Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): Remove defaults for demo index versions #4098

Closed
wants to merge 1 commit into from

Conversation

theodab
Copy link
Contributor

@theodab theodab commented Apr 5, 2022

These default versions, originally meant for testing, were showing
up in the actual site as it deployed. We're not really doing testing
on these scripts now that they are GitHub actions, so there's no harm
in removing that clause entirely.

Closes #4074

These default versions, originally meant for testing, were showing
up in the actual site as it deployed. We're not really doing testing
on these scripts now that they are GitHub actions, so there's no harm
in removing that clause entirely.

Closes shaka-project#4074
@theodab theodab added the component: demo page The issue is in the demo page; does not affect production applications label Apr 5, 2022
@theodab theodab requested a review from joeyparrish April 5, 2022 04:20
@joeyparrish
Copy link
Member

These default versions, originally meant for testing, were showing up in the actual site as it deployed. We're not really doing testing on these scripts now that they are GitHub actions, so there's no harm in removing that clause entirely.

I disagree. If we need to make changes to the script, we will need to test that locally before deployment. Running the local app server is still useful. Unless we switch to a non-appengine way to get the list of versions (querying GitHub tags, or something similar), we should keep this.

I think the real issue is that when I switched from Python 2 to Python 3, this line must have quit working:

if os.getenv('SERVER_SOFTWARE', '').startswith('Google App Engine/'):

I found the equivalent docs for GAE's Python 3 environment:
https://cloud.google.com/appengine/docs/standard/python3/tools/using-local-server#detecting_application_runtime_environment

if os.getenv('GAE_ENV', '').startswith('standard'):
  # Production in the standard environment
else:
  # Local development server

Could you please switch to that instead?

@theodab
Copy link
Contributor Author

theodab commented Apr 11, 2022

Okay. Because that's such a different approach from this, I'll submit a separate PR for it.

@theodab theodab closed this Apr 11, 2022
@theodab theodab deleted the indexVersions branch April 11, 2022 22:50
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index-dot-shaka-player-demo.appspot.com broken
2 participants