Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix -main tags on release #4154

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

joeyparrish
Copy link
Member

These tags should be attached to the head of the main branch, so that
is what we should check out during the tagging job.

In v3.1.7, v3.2.5, and v3.3.3, we accidentally tagged the heads of the
release branches. The -main tags for those releases had to be
corrected manually.

These tags should be attached to the head of the main branch, so that
is what we should check out during the tagging job.

In v3.1.7, v3.2.5, and v3.3.3, we accidentally tagged the heads of the
release branches.  The `-main` tags for those releases had to be
corrected manually.
@joeyparrish joeyparrish merged commit 71b6de8 into shaka-project:main Apr 25, 2022
@joeyparrish joeyparrish deleted the fix-main-tags branch April 25, 2022 22:51
joeyparrish added a commit that referenced this pull request Apr 26, 2022
These tags should be attached to the head of the main branch, so that
is what we should check out during the tagging job.

In v3.1.7, v3.2.5, and v3.3.3, we accidentally tagged the heads of the
release branches.  The `-main` tags for those releases had to be
corrected manually.
joeyparrish added a commit that referenced this pull request Apr 26, 2022
These tags should be attached to the head of the main branch, so that
is what we should check out during the tagging job.

In v3.1.7, v3.2.5, and v3.3.3, we accidentally tagged the heads of the
release branches.  The `-main` tags for those releases had to be
corrected manually.
joeyparrish added a commit that referenced this pull request Apr 26, 2022
These tags should be attached to the head of the main branch, so that
is what we should check out during the tagging job.

In v3.1.7, v3.2.5, and v3.3.3, we accidentally tagged the heads of the
release branches.  The `-main` tags for those releases had to be
corrected manually.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants