fix: Fix VP9 codec checks on Mac Firefox #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for VP9 codec checks were failing on Firefox on our M1 Mac. This addresses the issue by changing some default values that get used in a testing environment, and another default value that is used in production.
joeyparrish
added
type: code health
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
theodab
approved these changes
Aug 8, 2022
littlespex
approved these changes
Aug 8, 2022
avelad
approved these changes
Aug 8, 2022
JulianDomingo
approved these changes
Aug 8, 2022
joeyparrish
added a commit
that referenced
this pull request
Aug 16, 2022
Tests for VP9 codec checks were failing on Firefox on our M1 Mac. This addresses the issue by changing some default values that get used in a testing environment, and another default value that is used in production.
joeyparrish
added a commit
that referenced
this pull request
Aug 16, 2022
Tests for VP9 codec checks were failing on Firefox on our M1 Mac. This addresses the issue by changing some default values that get used in a testing environment, and another default value that is used in production.
joeyparrish
added a commit
that referenced
this pull request
Aug 16, 2022
Tests for VP9 codec checks were failing on Firefox on our M1 Mac. This addresses the issue by changing some default values that get used in a testing environment, and another default value that is used in production.
joeyparrish
added a commit
that referenced
this pull request
Aug 16, 2022
Tests for VP9 codec checks were failing on Firefox on our M1 Mac. This addresses the issue by changing some default values that get used in a testing environment, and another default value that is used in production.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for VP9 codec checks were failing on Firefox on our M1 Mac. This
addresses the issue by changing some default values that get used in a testing
environment, and another default value that is used in production.
This fixes one source of nightly test failures.