chore(HLS): Retired unused error code #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that shaka-project#2337 has been implemented, the error code HLS_INTERNAL_SKIP_STREAM is no longer used anywhere in the code. This retires that error, and also cleans up the code that previously was responsible for handling that error being fired. Pre-work for shaka-project#1936
theodab
added
type: code health
|
Incremental code coverage: 100.00% |
joeyparrish
approved these changes
Aug 19, 2022
joeyparrish
requested changes
Aug 19, 2022
I fixed the test failures. Turned out to be... something that the compiler really should have caught, annoyingly enough. Oh well. |
joeyparrish
approved these changes
Aug 20, 2022
echoy-harmonicinc
pushed a commit
to harmonicinc-com/shaka-player
that referenced
this pull request
Dec 6, 2022
Now that shaka-project#2337 has been implemented, the error code HLS_INTERNAL_SKIP_STREAM is no longer used anywhere in the code. This retires that error, and also cleans up the code that previously was responsible for handling that error being fired. Pre-work for shaka-project#1936
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #2337 has been implemented, the error code HLS_INTERNAL_SKIP_STREAM
is no longer used anywhere in the code.
This retires that error, and also cleans up the code that previously
was responsible for handling that error being fired.
Pre-work for #1936