feat: Allow to customize HLS Live behavior #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
|
Incremental code coverage: 100.00% |
theodab
requested changes
Oct 13, 2022
externs/shaka/player.js
Outdated
| * the availability window equal to the presentation delay. The player | ||
| * will be able to buffer ahead three segments, but the seek window will | ||
| * be zero-sized. | ||
| * <i>Defaults to <code>truecode>.</i> |
There was a problem hiding this comment.
The closing code tag is broken.
externs/shaka/player.js
Outdated
| @@ -858,6 +859,13 @@ shaka.extern.DashManifestConfiguration; | |||
| * format this value. | |||
| * <i>Defaults to | |||
| * <code>'video/mp2t; codecs="avc1.42E01E, mp4a.40.2"'</code>.</i> | |||
| * @property {boolean} useSafariBehaviorForLive | |||
| * The spec says nothing much about seeking in live content, but Safari's | |||
| * built-in HLS implementation does not allow it. Therefore we will set | |||
There was a problem hiding this comment.
The wording in the second sentence here is confusing. It isn't clear it's describing the effect of this configuration value.
I would explicitly describe it in terms of what happens if it's set to true, vs if it's set to false. Something like:
If this is true, playback will set the availability window to the presentation delay. The player will be able to buffer ahead three segments, but the seek window will be zero-sized, to be consistent with Safari.
If this is false, the seek window will be the entire duration.
theodab
approved these changes
Oct 16, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.