Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add external thumbnails with sprites support #4584

Merged
merged 2 commits into from
Oct 18, 2022
Merged

feat: Add external thumbnails with sprites support #4584

merged 2 commits into from
Oct 18, 2022

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 17, 2022

Continuation of #4497

@avelad avelad added type: enhancement New feature or request priority: P2 Smaller impact or easy workaround labels Oct 17, 2022
@avelad avelad added this to the v4.3 milestone Oct 17, 2022
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad merged commit 86cb3e7 into shaka-project:main Oct 18, 2022
@github-actions github-actions bot mentioned this pull request Oct 18, 2022
Merged
@avelad avelad deleted the thumbnails-sprites branch October 18, 2022 16:42
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @joeyparrish