fix: Fix potential AV sync issues after seek or adaptation #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After seeking or adaptation, StreamingEngine will create a new SegmentIterator. However, if the buffered ranges are different enough from the references in the iterator, and if sequence mode is active, this can cause StreamingEngine to append a duplicate segment instead of overwriting the end of one. Any time a new iterator is created, we force the stream to resync, so that unaligned segments or slightly-inaccurate segments are written to the correct place in the buffer. Issue shaka-project#4589
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo and
theodab
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
avelad
approved these changes
Jan 12, 2023
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
After seeking or adaptation, StreamingEngine will create a new SegmentIterator. However, if the buffered ranges are different enough from the references in the iterator, the lookup in the index can produce a duplicate segment. If this happens when sequence mode is active, StreamingEngine will append the duplicate segment instead of overwriting the end of the original one. Any time a new iterator is created, we force the stream to resync, so that unaligned segments or slightly-inaccurate segments are written to the correct place in the buffer. Issue #4589
joeyparrish
added a commit
that referenced
this pull request
Jan 13, 2023
After seeking or adaptation, StreamingEngine will create a new SegmentIterator. However, if the buffered ranges are different enough from the references in the iterator, the lookup in the index can produce a duplicate segment. If this happens when sequence mode is active, StreamingEngine will append the duplicate segment instead of overwriting the end of the original one. Any time a new iterator is created, we force the stream to resync, so that unaligned segments or slightly-inaccurate segments are written to the correct place in the buffer. Issue #4589
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
…ject#4886) After seeking or adaptation, StreamingEngine will create a new SegmentIterator. However, if the buffered ranges are different enough from the references in the iterator, the lookup in the index can produce a duplicate segment. If this happens when sequence mode is active, StreamingEngine will append the duplicate segment instead of overwriting the end of the original one. Any time a new iterator is created, we force the stream to resync, so that unaligned segments or slightly-inaccurate segments are written to the correct place in the buffer. Issue shaka-project#4589
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeking or adaptation, StreamingEngine will create a new SegmentIterator. However, if the buffered ranges are different enough from the references in the iterator, the lookup in the index can produce a duplicate segment. If this happens when sequence mode is active, StreamingEngine will append the duplicate segment instead of overwriting the end of the original one.
Any time a new iterator is created, we force the stream to resync, so that unaligned segments or slightly-inaccurate segments are written to the correct place in the buffer.
Issue #4589