Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): Fix labelling of captions in Safari #6426

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 10, 2024

Fixes #6233

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround browser: Safari Issues affecting Safari or WebKit derivatives labels Apr 10, 2024
@avelad avelad added this to the v5.0 milestone Apr 10, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 50.00%

@avelad avelad merged commit 35dd543 into shaka-project:main Apr 10, 2024
18 checks passed
avelad added a commit that referenced this pull request Apr 10, 2024
avelad added a commit that referenced this pull request Apr 10, 2024
@avelad avelad deleted the src-labelling-hls branch April 10, 2024 10:28
joeyparrish pushed a commit that referenced this pull request May 7, 2024
joeyparrish pushed a commit that referenced this pull request May 7, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(HLS) Labelling of captions and subtitles in Safari
3 participants