Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix exceptions in StreamingEngine when reloading #6466

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: Fix exceptions in StreamingEngine when reloading #6466

merged 1 commit into from
Apr 22, 2024

Commits on Apr 22, 2024

  1. fix: Fix exceptions in StreamingEngine when reloading 

    When reloading MediaSourceEngine via StreamingEngine, some logic executed
before the reload cancels operations and aligns StreamingEngine state with
MediaSourceEngine.

However, additional logic was executed after setStreamProperties, which caused
a race condition that broke StreamingEngine state by manipulating it out of the
usual sequence and outside the usual methods, leading to exceptions and failed
assertions.  This removes that unnecessary logic and leaves subtle state
management to the functions that are meant to do it.

Closes shaka-project#6458
    @joeyparrish
    joeyparrish committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cd5ff67 View commit details
    Browse the repository at this point in the history