test: Fix Tizen test failures #6540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes these failures on Tizen:
Player
rebufferGoal
✗ state orchestration and buffer length [Safari 3.0 (Tizen 3.0)]
Player Src Equals
✗ can control trick play rate [Safari 3.0 (Tizen 3.0)]
This was not in any releases.
Reverts "fix: reBufferingGoal is not respected (shaka-project#6433)"
This reverts commit 99ed5db.
Reopens shaka-project#6355
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
joeyparrish
changed the title
This was referenced May 7, 2024
|
Incremental code coverage: 100.00% |
alekzz
approved these changes
May 7, 2024
I hear you, but the titles are used to automate the generation of change logs. A revert in the title is hard to follow in the change log. Since the main consequence of this was fixing test failures, I put that in the title and moved the revert details to the commit message. |
joeyparrish
added a commit
that referenced
this pull request
May 7, 2024
Fixes these failures on Tizen:
Player
rebufferGoal
✗ state orchestration and buffer length [Safari 3.0 (Tizen 3.0)]
Player Src Equals
✗ can control trick play rate [Safari 3.0 (Tizen 3.0)]
This was not in any releases.
Reverts "fix: reBufferingGoal is not respected (#6433)"
This reverts commit 99ed5db.
Reopens #6355
joeyparrish
added a commit
that referenced
this pull request
May 7, 2024
Fixes these failures on Tizen:
Player
rebufferGoal
✗ state orchestration and buffer length [Safari 3.0 (Tizen 3.0)]
Player Src Equals
✗ can control trick play rate [Safari 3.0 (Tizen 3.0)]
This was not in any releases.
Reverts "fix: reBufferingGoal is not respected (#6433)"
This reverts commit 99ed5db.
Reopens #6355
joeyparrish
added a commit
that referenced
this pull request
May 7, 2024
Fixes these failures on Tizen:
Player
rebufferGoal
✗ state orchestration and buffer length [Safari 3.0 (Tizen 3.0)]
Player Src Equals
✗ can control trick play rate [Safari 3.0 (Tizen 3.0)]
This was not in any releases.
Reverts "fix: reBufferingGoal is not respected (#6433)"
This reverts commit 99ed5db.
Reopens #6355
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these failures on Tizen:
Player
rebufferGoal
✗ state orchestration and buffer length [Safari 3.0 (Tizen 3.0)]
Player Src Equals
✗ can control trick play rate [Safari 3.0 (Tizen 3.0)]
This was not in any releases.
Reverts "fix: reBufferingGoal is not respected (#6433)"
This reverts commit 99ed5db.
Reopens #6355