Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Xbox - round gap jumping values #6695

Merged
merged 3 commits into from
May 29, 2024
Merged

fix: Xbox - round gap jumping values #6695

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b86b108
fix: Xbox - round gap jumping values
tykus160 May 28, 2024
5e7c484
Update lib/media/gap_jumping_controller.js
tykus160 May 29, 2024
2592c37
lint
tykus160 May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/media/gap_jumping_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ goog.require('shaka.media.TimeRangesUtils');
goog.require('shaka.util.EventManager');
goog.require('shaka.util.FakeEvent');
goog.require('shaka.util.IReleasable');
goog.require('shaka.util.Platform');
goog.require('shaka.util.Timer');


Expand Down Expand Up @@ -217,7 +218,14 @@ shaka.media.GapJumpingController = class {

// StreamingEngine can buffer past the seek end, but still don't allow
// seeking past it.
const jumpTo = buffered.start(gapIndex);
let jumpTo = buffered.start(gapIndex);
// Workaround for Xbox with Legacy Edge. On this platform video element
// often rounds value we want to set as currentTime and we are not able
// to jump over the gap.
if (shaka.util.Platform.isLegacyEdge() ||
shaka.util.Platform.isXboxOne()) {
jumpTo = Math.ceil((jumpTo + 0.01) * 100) / 100;
}
const seekEnd = this.timeline_.getSeekRangeEnd();
if (jumpTo >= seekEnd) {
return;
Expand Down
Loading