Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DASH): Disable xlink processing by default #7264

Merged
merged 2 commits into from
Sep 5, 2024
Merged

feat(DASH): Disable xlink processing by default #7264

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88b0db2
feat(DASH): Disable xlink processing by default
avelad Sep 5, 2024
3037faf
fix test
avelad Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion demo/common/assets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,14 @@ shakaAssets.testAssets = [
.addFeature(shakaAssets.Feature.MP4)
.addFeature(shakaAssets.Feature.WEBM)
.addFeature(shakaAssets.Feature.XLINK)
.addFeature(shakaAssets.Feature.OFFLINE),
.addFeature(shakaAssets.Feature.OFFLINE)
.setExtraConfig({
manifest: {
dash: {
disableXlinkProcessing: false,
},
},
}),
// From: http://dig.ccmixter.org/files/JeffSpeed68/53327
// Licensed under Creative Commons BY-NC 3.0.
// Free for non-commercial use with attribution.
Expand Down
2 changes: 1 addition & 1 deletion externs/shaka/player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,7 +1096,7 @@ shaka.extern.xml.Node;
* @property {boolean} disableXlinkProcessing
* If true, xlink-related processing will be disabled.
* <br>
* Defaults to <code>false</code>.
* Defaults to <code>true</code>.
* @property {boolean} xlinkFailGracefully
* If true, xlink-related errors will result in a fallback to the tag's
* existing contents. If false, xlink-related errors will be propagated
Expand Down
2 changes: 1 addition & 1 deletion lib/util/player_configuration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ shaka.util.PlayerConfiguration = class {
dash: {
clockSyncUri: '',
ignoreDrmInfo: false,
disableXlinkProcessing: false,
disableXlinkProcessing: true,
xlinkFailGracefully: false,
ignoreMinBufferTime: false,
autoCorrectDrift: true,
Expand Down
Loading