Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(DASH): Create segment indexes only on new periods #7294

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

tykus160
Copy link
Member

Old references to segment index are already stored in meta segment index, so there's no reason to recreate them.

@tykus160 tykus160 added type: performance A performance issue component: DASH The issue involves the MPEG DASH manifest format labels Sep 12, 2024
@avelad avelad added the priority: P1 Big impact or workaround impractical; resolve before feature release label Sep 12, 2024
@avelad avelad modified the milestones: v4.11, v4.12 Sep 12, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 173a814 into shaka-project:main Sep 12, 2024
17 of 18 checks passed
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
Old references to segment index are already stored in meta segment
index, so there's no reason to recreate them.
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
Old references to segment index are already stored in meta segment
index, so there's no reason to recreate them.
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
Old references to segment index are already stored in meta segment
index, so there's no reason to recreate them.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 11, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: performance A performance issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants