Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Offline): Allow store external thumbnails #7322

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat(Offline): Allow store external thumbnails #7322

merged 1 commit into from
Sep 17, 2024
+243 −12

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 16, 2024

Related to #2016

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: offline The issue involves the offline storage system of Shaka Player labels Sep 16, 2024
@avelad avelad added this to the v4.12 milestone Sep 16, 2024
@avelad
Copy link
Member Author

avelad commented Sep 16, 2024

Note: In a later PR I will allow storing subtitles externally.

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 28.18%

@avelad avelad merged commit 013b3c7 into shaka-project:main Sep 17, 2024
18 of 20 checks passed
@avelad avelad deleted the store-external-thumbnails branch September 17, 2024 07:45
@shaka-bot shaka-bot mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: offline The issue involves the offline storage system of Shaka Player priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab