Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(offline): Text segments are downloaded before audio&video #7336

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 18, 2024

Support for using the old parallel download mechanism is also added.

Fixes: #4878

@avelad avelad requested a review from theodab September 18, 2024 09:23
@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: offline The issue involves the offline storage system of Shaka Player labels Sep 18, 2024
@avelad avelad added this to the v4.12 milestone Sep 18, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 90.00%

@avelad avelad merged commit e28a07e into shaka-project:main Sep 18, 2024
18 of 19 checks passed
@avelad avelad deleted the offline-text-download branch September 18, 2024 11:04
avelad added a commit that referenced this pull request Sep 18, 2024
Support for using the old parallel download mechanism is also added.

Fixes: #4878
avelad added a commit that referenced this pull request Sep 18, 2024
Support for using the old parallel download mechanism is also added.

Fixes: #4878
joeyparrish pushed a commit that referenced this pull request Sep 18, 2024
Support for using the old parallel download mechanism is also added.

Fixes: #4878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: offline The issue involves the offline storage system of Shaka Player priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shaka Offline Download - Text segments are downloaded before audio&video
3 participants