Shakapacker Version 7 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Shakapacker module, config files, and env variables * Update tests to use shakapacker module and config files * Rename rake files to shakapacker * rename binstubs in test app * Update rake tasks and their specs * Update shakapacker_precompile entry in config file * Fix installation scripts * Replace remaining instances of webpacker * Update JS code and tests * Update description of clean rake tasks * Update changelog * Add v7 upgrade guide * Change Webpacker reference to Shakapacker in docs * Update Readme and contribution guide for shakapacker
* Use Shakapacker module, config filesm, and env variables * Rename rake files to shakapacker * Update JS code and tests * Fix conflict * Update Readme and contribution guide for shakapacker * Remove debug lines * Fix linter issue * Use Shakapacker module, config filesm, and env variables * Add support for old configfile * Add rake tasks * Add files to support requiring Webpacker module * Add backward compatibility test * Add rake task for backward compatibility test * Add CI for backward compatibility specs * Add backward compatibility to JS package * Add backward compatibility for --debug-shakapacker option * Fix chdir in afterAll hook in js tests * Fix js tests for compiling files in source_path * Use symlink address for config file * Use fs.existsSync to check if file exist * Remove a redundant assignment * Improve deprecation messages * Improve gitignore in test apps * Improve deprecation message for env variables * Update documentation * Show deprecation message for old binstubs * Update changelog * Add and improve test for custom config path in env variable * Improve robustness in config.fetch method * Update docs * Update deprecation message * Simplify config.fetch method * Remove lines releated to git conflict * Improve the order of code * Add v7 upgrade guide link to changelog
* Update Changelog * Simplify docs for spelling change
* Remove redundant code for enhancing precompile task
* Set allowed_host to auto as per webpack recommendation * Use server: http instead of https: false * Remove server entry from config and improve value detection * Add support for hash value for server entry * Update dev_server_runner to use protocol * Add server or https entry conditionally * Add support for other standard devServer config In this commit, I add support for those keys written in snake-case to be added to the configurations in camel-case format, if they are set. The logic for mapping keys in the shakapacker.yml file is straightforward: if a key is specific to webpack, it will be mapped to camelCase; otherwise, the key will remain as is. Any other key not specific to webpack (such as random_key) will remain accessible in its original form. * Run the logic only in a dev environment * Set specific exception type for rescue
|
I am wondering if using |
ahangarha
force-pushed
the
shakapacker-v7
branch
from
6c507a9
to
d3128c7
Compare
* Stop stripping out top level directories in file loader * Account for top level files * Add changelog entry * Don't use dynamic source path
* Set source_entry_path to packs * Process source_entry_path as a relative path * Improve comments for source_entry_path * Set nested_entries to true in config file
justin808
changed the title
|
Are we ready to put a beta version out with this? @tomdracz @ahangarha |
ahangarha
changed the title
tomdracz
approved these changes
Apr 27, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All spellings for Webpacker are renamed to Shakapacker.
Pull Request checklist
These changes are tested on react_on_rails_demo_ssr_hmr.
closes #157