Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic recognition #443

Open
wants to merge 27 commits into
base: topic-recognition
Choose a base branch
from

Conversation

alexvillr
Copy link

Hiya,
This pull request is for an implementation of problem 8 (Create a generative model of one of the OASIS brain, ADNI brain or the OAI AKOA knee data set (see Appendix for links) using a VQVAE [11] or VQVAE2 [12] that has a “reasonably clear image” and a Structured Similarity (SSIM) of over 0.6)

Please find contained within
interface.ipynb containing the main interface for interacting with my models
README.md containing information on how the models work together including how to use the models yourself
dataset.py containing the code used to implement the various datasets and data loaders used throughout
predict.py containing the code for generating new images
train.py containing the code used for the training loops for the various models
environment.yml containing the environment used during the creation of this project
images/*.png containing the images used in the README
modules/*.py containing the various models used in this project

  • modules.decoder.py decoder implementation
  • modules.encoder.py encoder implementation
  • modules.quantizer.py vector quantizer implementation
  • modules.stack.py implementation for the stacked residual layers used by other modules
  • modules.vqvae.py VQ-VAE implementation
  • modules.pixelcnn.py pixel cnn implementation

Thank you for your time taken to review and hope for feedback.

Alex Viller,
45375325

@SiyuLiu0329
Copy link
Collaborator

This is an initial inspection, no action is required at this point

  • Reconstruction: OK
  • Generation: code seem largely OK. I can see the model code and image generation code. Logic seems correct. No results due to some errors.

@shakes76
Copy link
Owner

shakes76 commented Nov 18, 2022

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate use and implementation (some errors prevented it from working, partially working) -3
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem (some outputs missing) -2
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage (no plots, no full output) -2
Module present
Commenting
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages
Progressive commits used

Documentation

ReadMe acceptable
Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
Feedback required, undo/revert changes to other student files and conflicts -2
Request Description good

@alexvillr
Copy link
Author

I see that I need to undo/revert changes to other student files. I don't remember making those changes I think it might have happened from having some kind of inconsistency between my version and the public version when I submitted the pull request. For fixing these changes should I just edit the files so they are identical to the other students ones?

@alexvillr
Copy link
Author

I've attempted to get rid of my changes to other students read me and even after copying and pasting from origin and attempting git checkout origin/topic-recognition -- recognition/ISICs_UNet/README.md and git checkout origin/topic-recognition -- recognition/XUE4645768/Readme.md and then commiting after that it seems like I cannot get rid of these changes. Any tips?

@shakes76
Copy link
Owner

Seems the student files still showing up as changed. Can you check again. I will grant the Feedback marks, because you did attempt to solve it, but can't merge until you do fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants