Ability to set path style for buckets #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've self-hosted s3 service that does not support specifies buckets by domain.
But it supports path style buckets, like this:
https://s3.example.net/{bucket}/
When I tried to use this action for
site
bucket at thes3.example.net
, I got an errorAfter research the aws-sdk library led me to the s3ForcePathStyle field which allows to change this behavior.
So, I added this field as
force_path_style
to action and changed workflow:- uses: shallwefootball/s3-upload-action@master with: aws_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY}} aws_bucket: site source_dir: ./client/build destination_dir: public endpoint: https://s3.example.net/ + force_path_style: true
Now it works well!
The only thing is... I'm newbie at the object storage, maybe I could achieve the same goal in an alternative way?