Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GITHUB_TOKEN from build job env #46

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Remove GITHUB_TOKEN from build job env #46

merged 2 commits into from
Sep 20, 2022

Conversation

casey
Copy link
Contributor

@casey casey commented Sep 16, 2022

I believe that this isn't necessary, since we're building and not deploying.

Thanks for this great project!

@shalzz
Copy link
Owner

shalzz commented Sep 17, 2022

Can you instead comment it out and add an explanation why its not needed when BUILD_ONLY is true (in a comment line)

@casey
Copy link
Contributor Author

casey commented Sep 20, 2022

Sure, done!

@shalzz shalzz merged commit 1baf4e9 into shalzz:master Sep 20, 2022
@shalzz
Copy link
Owner

shalzz commented Sep 20, 2022

Thanks

@casey casey deleted the patch-2 branch September 20, 2022 03:32
@fredr fredr mentioned this pull request Jan 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @shalzz