Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep output of CLI installation command #628

Closed
borekb opened this issue Aug 30, 2018 · 7 comments
Closed

Keep output of CLI installation command #628

borekb opened this issue Aug 30, 2018 · 7 comments

Comments

@borekb
Copy link

borekb commented Aug 30, 2018

As discussed in #618 (comment), it would be useful to keep the output of extension installation, something like:

CODE SETTINGS SYNC - COMMAND LINE EXTENSION DOWNLOAD SUMMARY
Version: 3.1.0
------------------------
TOTAL EXTENSIONS : 3

"/usr/share/code/bin//code" --install-extension alefragnani.Bookmarks
Found 'alefragnani.Bookmarks' in the marketplace.
Installing...
Extension 'alefragnani.Bookmarks' v9.0.3 was successfully installed!

EXTENSION : 1 / 3 INSTALLED.

"/usr/share/code/bin//code" --install-extension msjsdiag.debugger-for-chrome

image

Currently, it is replaced by the final summary after a short while.

@shanalikhan
Copy link
Owner

Don't you think by showing it with summary creates a long log trail on each download transaction, if a user has above 20 extensions, it will a long output channel and a summary will be shown at the end.

@borekb
Copy link
Author

borekb commented Aug 31, 2018

I think the output would scroll to the bottom so I'd still see roughly the same as today but with the added benefit of being able to scroll up.

Second, it's very rare for me to install all extensions, maybe on a clean computer once in a while. Much more common is removing / adding one or two extensions and syncing those between computers. So the extension installation logs would typically be empty or short.

@shanalikhan shanalikhan added this to the v3.2 milestone Sep 4, 2018
@IssueHuntBot
Copy link

@loadbalance-sudachi-kun funded this issue with $256. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@shanalikhan has started working. Visit this issue on Issuehunt

shanalikhan pushed a commit that referenced this issue Oct 9, 2018
@IssueHuntBot
Copy link

@shanalikhan has submitted output. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@shanalikhan has rewarded. Visit this issue on Issuehunt

shanalikhan added a commit that referenced this issue Oct 17, 2018
* chore(package): update tslint-plugin-prettier to version 2.0.0

* Updated: German translation

* #641

* Add support for VSCodium

* Corrected the message to be displayed

* Add Japanese translation file

* be able to upload additional file

* be able to download additional files

* create new advanced setting to add Customized Sync file

* fix typo eslint => eslintrc

* Add Import Custom File to workspace option

* unify display message: Custom Sync File

* Test Directory

* =Adding HostName property. Get hostname using 'os.hostname()'

* =Need definition for supported OS's. Using strict match regex to get @sync pragmas. Should it support multiple spaces? Replacing settings.json content before writing file. Should be better removing lines instead of add comments? Replacing settings.json before upload to remove @sync ignore pragms.

* Added English message for OSNotSupported message while processing uploading content

* mocha and chai packages added as dev dependencies. Test script not working while compiling.

* Moving pragma functions to a separated file

* Added Pragma util static class. Support for host, env and os values in every orther. Remove whitespaces before upload. Alert user if OS value is not a valid OS.

* Added hostName property to CustomSettings

* Tests files added. Estructure test per feature.

* Added some documentation. hostName property on custom config.

* uncomment lines function. Uncomment all @sync settings before upload. Only insert comments if it doesn't match with matchine os or host or env. Uncomment line before write if it matched.

* Do replace ments one time per setting pragma. Test uncoment function. More redeable settings json for testing.

* Add SUPPORTED_OS and osTypeFromString to environmentPath.ts as requested. Get OS from OsType enum. Remove os.hostName()

* Check valid JSON before writting file. All the comments and trilling commas are removed. Must check this. If not valid OS is detected inform user. Added function to remove comments from text.

* Chatch exception during upload. Should it abort upload?

* Adding VS Code tests in typescript. Run test changing launch mode to "Launch Test". Remove javascript files.

* Environment - treat non-OSS instalations on Linux as XDG

* Improvements
#628 , #629

* minor grammatical fixes

* add fileService.test.ts

* Version Change

* #331

* #513

* Add webpack bundling (#676)

* Update issue templates

* add webpack bundling for faster startup

* no conflicts

* Revert "Add webpack bundling (#676)" (#679)

This reverts commit e68a243.

* Gist Object changed

* Update package.json

* v3.2 change log
@shanalikhan
Copy link
Owner

Fixed in v3.2
let me know if there is any problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants