Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with input closing when losing focus #54

Merged
merged 1 commit into from
Jul 30, 2016

Conversation

massimocode
Copy link
Contributor

Several things to note:

  • When the input box loses focus it closes, and the promise resolves with undefined. We simply reopen the input box if that is the case.
  • When the user genuinely wants to close the wizard (by pressing escape), the promise resolves with undefined. Since we have no way of telling if this value undefined is because the user has cancelled the wizard or because the editor has lost focus, we have to assume the editor has lost focus (because that's what happens when we open the GitHub link).
  • So how does the user genuinely close the wizard? We allow the user to cancel the wizard by typing esc and pressing enter. We check for this value and do not reopen the input box if this was what the user typed.

@shanalikhan
Copy link
Owner

yes that could be one option. thanks will publish the extension soon

@shanalikhan shanalikhan merged commit 70a4fed into shanalikhan:master Jul 30, 2016
lilsunny243 added a commit to lilsunny243/code-settings-sync that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants