fix(extensions): change portable extensions dir #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Is your |
|
you mean |
|
I'm talking about setting |
|
Tested with |
|
Great, Thanks. Feel free to look into other issues as well when you have time :) |
shanalikhan
pushed a commit
that referenced
this pull request
Mar 5, 2019
shanalikhan
reviewed
Mar 6, 2019
| @@ -9,8 +9,8 @@ import * as util from "../util"; | |||
| const apiPath = | |||
| "https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery"; | |||
|
|
|||
| const extensionDir: string = ".vscode"; | |||
| const extensionDirPortable: string = "/data/extensions/"; | |||
| const extensionDir: string = ".vscode/"; | |||
There was a problem hiding this comment.
adding / caused in this string stopped the syncing
There was a problem hiding this comment.
Exactly! It's because the path delimiter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Solves the issue #756 caused by a hardcoded extension dir.
This is a temporary workaround and we should use the env variables to check a valid extension dir instead of hardcoded ones:
Changes proposed in this pull request:
The
extensionDirvariable was changed to.vscode/to prevent the sync of "something" with.vscodein its name. (ex:bung87.vscode-gemfile)https://github.com/chase9/code-settings-sync/blob/36461174f534fefc4bce03a6f4ca182090287360/src/service/pluginService.ts#L12
The
extensionDirPortablevariable was changed to/extensions/because the path for the extensions folder in a portable VSCode instance, isextensionshttps://github.com/chase9/code-settings-sync/blob/36461174f534fefc4bce03a6f4ca182090287360/src/service/pluginService.ts#L13
Ref to
extensionspath in vscode:https://github.com/Microsoft/vscode/blob/14f25a610224cea1b7fc97da63ad2304951f60a5/src/vs/platform/environment/node/environmentService.ts#L168
Fixes: #756
How Has This Been Tested?
The extension was "installed" in a portable vscode and executed to sync the settings. It works nicely.
Checklist:
PS: There is no v3.2.6 branch as the contribution guidelines says.