Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove gallery installation check #791

Merged
merged 1 commit into from
Mar 6, 2019
Merged

fix: remove gallery installation check #791

merged 1 commit into from
Mar 6, 2019

Conversation

LuisUrrutia
Copy link
Contributor

Short description of what this resolves:

This solves #756.

Changes proposed in this pull request:

  • Remove the gallery installation check, because isn't a good validation (It can be "bypassed" and just adds complexity. In the worst-case scenario, the extension will not be installed.

Fixes: #756

How Has This Been Tested?

Tested with "Launch extension" and autoUpdate on and off.

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.

@shanalikhan shanalikhan changed the base branch from master to v3.2.7 March 6, 2019 11:02
@shanalikhan shanalikhan merged commit c74aaeb into shanalikhan:v3.2.7 Mar 6, 2019
@LuisUrrutia LuisUrrutia mentioned this pull request Mar 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuisUrrutia @shanalikhan