Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul extension (WIP) #814

Closed
wants to merge 68 commits into from
Closed

Overhaul extension (WIP) #814

wants to merge 68 commits into from

Conversation

auxves
Copy link
Contributor

@auxves auxves commented Mar 31, 2019 •
edited
Loading

Short description of what this resolves:

This PR adds support for repositories, adds a GUI for settings, and fixes auto upload.

Changes proposed in this pull request:

Fixes: 1
Improvements: 2

How Has This Been Tested?

I have tested almost everything the extension can do using the VSCode debugger, and everything worked as expected. However, I haven't tested features like sync pragmas and public gist

Screenshots (if appropriate):

Gist Settings
Repo Settings

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.*
  • I have updated the documentation and Wiki accordingly.*

* I haven't yet updated the wiki, but I have updated README.md

Current Progress:

  • Works with GitHub, BitBucket, and GitLab
  • Works with SSH keys
  • Allow the user to use either gist or repo
  • Set up repo if needed
  • Create a repository without user intervention
  • Use branches to store different profiles
  • Upload to a repository
  • Download from a repository
  • Properly ignore files using .gitignore
  • Auto upload fixed

@auxves
Rework services
93164de
@auxves
Import chokidar
0cca0a0
@auxves
Install chokidar and some type definitions
80b3bb3
@auxves
Use chokidar and different service for watching
0fd6b9a
@auxves
Only import needed functions
2ee3c2e
@auxves
Seperate gist and repo settings
64ebde6
@auxves
Migrate to support both repo and gist sync
3fdede7
@auxves
Add autoUpload service
d076fc3
@auxves
Restore original file contents
1390bc9
@auxves
Make config simpler and allow for autocomplete
2a0de59
@auxves
Add comma :)
ef87eb8
@auxves
Remove old files
be2142f
@auxves
Fix file associations
a388b17
@auxves
Improve fileService
8e46544
@auxves
Update file properties to be simpler
29b7509
@auxves
Update sync to use synchronous booleans
b628c48
@auxves
Update file properties
24565df
@auxves
Make creating ExtensionMetadata much easier
cabe50e
@auxves
Fix to work with updated properties
b31a394
@auxves
Use synchronous methods for small functions
053897f
@auxves
Use synchronous functions when await is not needed
073aa18
@auxves
Update settings and remove unnecessary class
f023a6c
@auxves
Add packages
f7cc021
@auxves
Implement GUI for settings
183658c
@auxves
Add new settings
c337fde
@auxves
Fix setting names
df3962a
@auxves
Fix tests
279c003
@auxves
Add settings page
8220739
@auxves
Display current values on settings page
6c3edfe
@auxves
Set default sync method
1ba7f6b
@auxves
Make commands consistent
4614a7c
@auxves
Move extConfig to here and organize neatly
db13734
@auxves
Allow for both Gist and Repo services to work
457e30a
@auxves
Make a service for watcher
316e3c1
@auxves
Create async commands for when they are needed
aed4e6d
@auxves
Fix error with baseUrl
1107936 
Revert SaveGist() because it wasn't working properly
@auxves
Add all files to repo
119838d 
Always update gitignore with most recent ignored files and folders
@auxves
Update to match setting.ts's configuration
d97cd80
@auxves
Update to use new "ignoredSettings" variable name
6b1d291
@auxves
Simplify function
fc638c5
@auxves
Create classes for better intellisense
2140527
@auxves
Use better solution for custom files
3f8102d
@auxves
Fix bug
b02ebfc 
This event would be called many times, so there would be lots of
functions being called. Now it is only called in the constructor and
only works when watching is true
@auxves
Fix issue with my previous changes
6a4a639
@auxves
Add extensions.json after content files
78e35fd 
This fixes an issue where uploading to gist would not upload
new extensions file
@auxves
Remove console log that was used for testing
15f92a2 
Add a colon after event to make it easier to differentiate between
events
@auxves
Put back code to delete files that no longer exist
b26a19c
@auxves
Stop updating gitignore every time
e783e5a 
This was detected as a change by git and uploaded even if the file
had not changed
@auxves
Update docs
f246e0f
@auxves
Show summary by default
e541570
@auxves
Open GitHub token page if gist is not configured
c1c198f
@auxves
Forcefully push and pull
7fd7ab9
@auxves auxves changed the title Overhaul extension Overhaul extension (WIP) Mar 31, 2019
@auxves auxves mentioned this pull request Mar 31, 2019
Merged
3 tasks
@shanalikhan
Copy link
Owner

shanalikhan commented Mar 31, 2019 •
edited
Loading

Thank you for your work so far. But Please stop, you are changing alot of things in one PR.
Settings Sync is being in 3 Million machines and it not feasible to just publish alot of changes in just a one PR.
As there are alot of test cases which is tested so far while developing this, any case might fail ends up not working to all of those users.

Move the watcher function into separate service and use chokidar

Lets use that PR and release that fix independently.

I will suggest you to solve these tickets in seperate PR instead of "complete overhual".
Look into those ticket items requirements seperately ( which is the acceptance requirement for those tickets , like how Git needs to be integrated with Settings sync. )

@auxves
Copy link
Contributor Author

auxves commented Mar 31, 2019

Ok, I will do that. The reason I did a complete overhaul was because a lot of the changes depended on each other. I added the settings page so it would be easier to change the new settings that adding repo support would bring.

@auxves auxves closed this Mar 31, 2019
@shanalikhan
Copy link
Owner

Great, Thanks.
Looking forward.

@auxves auxves deleted the git-repo branch June 2, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auxves @shanalikhan