Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to task api 2.0.0 and fixed tests #855

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Updated to task api 2.0.0 and fixed tests #855

merged 1 commit into from
Apr 21, 2019

Conversation

njkevlani
Copy link
Contributor

Launch Tests was broken. Fixed that.

Now Tests can be run by:

  1. Clone repo
  2. cd path/to/code-settings-sync && npm install && code .
  3. Launch Extension by pressing F5
  4. From Debugger menu, start Launch Tests

Fixes: #841

How Has This Been Tested?

By running the tests using above steps :P

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.

@shanalikhan shanalikhan added this to the v3.3.0 milestone Apr 19, 2019
@shanalikhan shanalikhan changed the base branch from master to v3.3.0 April 19, 2019 13:56
@njkevlani
Copy link
Contributor Author

Sorry about the conflicts,

The reason was
when I made a PR with v3.2.8 the main active branch was v3.2.9 and
when I made a PR with v3.2.9 the main active branch was v3.3.0

@shanalikhan shanalikhan merged commit 00dfd46 into shanalikhan:v3.3.0 Apr 21, 2019
@njkevlani
Copy link
Contributor Author

@shanalikhan

Have update Contribution Page accordingly. LMK if any changes required. Do we need to update CONTRIBUTING.md as well?

@shanalikhan
Copy link
Owner

Yes send a PR for CONTRIBUTING.md as well.
you can improve the both contributing page where you think it can be improved ( specially those parts which are hard for first time user to understand )

@njkevlani
Copy link
Contributor Author

#881 is open :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants