Add check to disable validate_records, add support unsigned number using minLength
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target_clickhouse/sinks.py
Outdated
Comment on lines
180
to
181
| if self.validate_schema: | ||
| self._validator.validate(record) |
There was a problem hiding this comment.
Would it make sense to convert this whole try-except block into return super()._validate_and_parse(record)?
There was a problem hiding this comment.
Ah yes, only now I have time look at the parent method, looks identical. I was in rush to fix on prod yesterday so didn't read everything. Thank @edgarrmondragon for the suggestion.
vietvudanh
changed the title
minLength
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meltano SDK has config
validate_recordsto disable records validation. However when it is set tofalse,self._validatorisNone, cause the sink flow raise error.This PR add a simple check to skip running validate when the flag is False.