Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet._isWalletType/isWalletType(wallet)-style type guards are verbose and redundant #466

Open
mrnerdhair opened this issue Mar 14, 2022 · 0 comments
Open

wallet._isWalletType/isWalletType(wallet)-style type guards are verbose and redundant #466

mrnerdhair opened this issue Mar 14, 2022 · 0 comments
Labels
tech-debt A suboptimality that existed in code when it was written.
Milestone
hdwallet++

Comments

@mrnerdhair
Copy link
Contributor

The standard instanceof type guard provides all the utility these guards provide, and requires no extra manually-added (and manually-maintained) type information. Removing them will simplify the library API and the implementation of new wallets.

  • Replace all wallet._isWalletType/isWalletType(wallet)-style type guards with usage of instanceof.

Fixed by #435.
@mrnerdhair mrnerdhair added the tech-debt A suboptimality that existed in code when it was written. label Mar 14, 2022
@mrnerdhair mrnerdhair linked a pull request Mar 17, 2022 that will close this issue
refactor: remove isWalletType introspection functions #435
Closed
@mrnerdhair mrnerdhair mentioned this issue Mar 23, 2022
Merged
@mrnerdhair mrnerdhair added this to the hdwallet++ milestone Mar 25, 2022
@mrnerdhair mrnerdhair mentioned this issue Apr 1, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt A suboptimality that existed in code when it was written.
Projects
None yet
Milestone
hdwallet++
Development

Successfully merging a pull request may close this issue.

refactor: remove isWalletType introspection functions shapeshift/hdwallet
1 participant
@mrnerdhair