Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove isWalletType introspection functions #435

Closed
wants to merge 1 commit into from
Closed

refactor: remove isWalletType introspection functions #435

wants to merge 1 commit into from

Conversation

mrnerdhair
Copy link
Contributor

@mrnerdhair mrnerdhair commented Feb 12, 2022 •
edited
Loading

instanceof makes implementing new wallet types easier (and everything less messy)

@vercel
Copy link

vercel bot commented Feb 12, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shapeshift/hdwallet/AZdJQRa2aMECqAzU61KUBUXwfGMa
✅ Preview: https://hdwallet-git-remove-is-wallet-type-shapeshift.vercel.app

@mrnerdhair mrnerdhair mentioned this pull request Feb 12, 2022
Closed
0xApotheosis
0xApotheosis approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

@mrnerdhair
Copy link
Contributor Author

for reference, this is an axiom-breaking change.

@mrnerdhair mrnerdhair added breaks-axiom reopen-later Stuff that's good to go but not a priority at the moment. labels Mar 4, 2022
@mrnerdhair mrnerdhair closed this Mar 5, 2022
@mrnerdhair mrnerdhair added this to the Low Priority milestone Mar 5, 2022
@mrnerdhair mrnerdhair mentioned this pull request Mar 14, 2022
Open
@mrnerdhair mrnerdhair linked an issue Mar 17, 2022 that may be closed by this pull request
wallet._isWalletType/isWalletType(wallet)-style type guards are verbose and redundant #466
Open
@mrnerdhair mrnerdhair modified the milestones: Low Priority, hdwallet++ Mar 22, 2022
@mrnerdhair mrnerdhair mentioned this pull request Mar 23, 2022
Merged
@mrnerdhair mrnerdhair mentioned this pull request Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees
No one assigned
Labels
reopen-later Stuff that's good to go but not a priority at the moment.
Projects
None yet
Milestone
hdwallet++
Development

Successfully merging this pull request may close these issues.

wallet._isWalletType/isWalletType(wallet)-style type guards are verbose and redundant
2 participants
@mrnerdhair @0xApotheosis