Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Cannot POST" error for PaymentMethodsForm: #1279

Closed
wants to merge 1 commit into from
Closed

Fix "Cannot POST" error for PaymentMethodsForm: #1279

wants to merge 1 commit into from

Conversation

rush1506
Copy link
Contributor

  • When using npm, the null handleSubmit would override the FinalForm handleSubmit method
  • This would cause error when the form is submit because the formRenderProps give out null handleSubmit function

@rush1506
Fix "Cannot POST" error for PaymentMethodsForm:
cb333e4 
- When using npm, the null handleSubmit would override the FinalForm handleSubmit method
- This would cause error when the form is submit  because the formRenderProps give out null handleSubmit function
@Gnito
Copy link
Contributor

Gnito commented May 12, 2020

Thanks, and sorry - this PR has been here unnoticed for a while. I'll check this code soonish.

@Gnito Gnito mentioned this pull request May 13, 2020
Merged
@Gnito
Copy link
Contributor

Gnito commented May 13, 2020

I close this one since the actual commit was merged in different PR.

@Gnito Gnito closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rush1506 @Gnito