Dev API server #1297
Dev API server #1297
Conversation
package.json
Outdated
| @@ -84,7 +85,8 @@ | |||
| "audit": "yarn audit --json | node scripts/audit.js", | |||
| "clean": "rm -rf build/*", | |||
| "config": "node scripts/config.js", | |||
| "dev": "node scripts/config.js --check && sharetribe-scripts start", | |||
| "api-server": "nodemon --watch server server/apiServer.js", | |||
| "dev": "node scripts/config.js --check&&concurrently -k \"sharetribe-scripts start\" \"API_SERVER_PORT=3500 yarn run api-server\"", | |||
There was a problem hiding this comment.
Is it planned that you can't run the web app without api-server running on the background?
That sounds bad since it increases complexity for everybody. Could we add another script that just opens the hot-loading mode (as 'dev' did before?)
There was a problem hiding this comment.
With the word 'complexity', I'm a bit worried about environments that we are not actively testing (e.g. running the app on windows)
There was a problem hiding this comment.
Yep, this definitely brings in complexity. The whole point of this work is to have FTW do the price calculation, and using that with flexible pricing and privileged transitions must be done in the backend.
This does take away the possibility to only deploy statically, but IMO we haven't noticed a strong need for that, and we've also always recommended Heroku as a deployment solution. I hope this paves the way to a different setup than the CRA fork, hopefully something like Next.js in the future where backend integration is a lot simpler.
We can have a separate client-only dev server, but then the process transitions would fail, and I assume that would only increase confusion and our support that is needed. That is assuming that backend-pricing becomes the new default.
This PR adds a simple server that is used to start up the API routes during build time.
TODO: