Make -pp override --paging and vice versa when passed as a later argument. #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enselic
reviewed
Sep 6, 2023
Enselic
reviewed
Sep 8, 2023
| #[test] | ||
| fn enable_pager_if_disable_paging_flag_comes_before_paging() { | ||
| bat() | ||
| .env("PAGER", "echo pager-output") |
There was a problem hiding this comment.
Thank you for the rebase @J-Kappes .
@boyvanduuren I don't understand how this new test can pass on Windows. It is rebased on your work, so shouldn't this need mocked_pagers::from()? Is CI not working as we expect?
There was a problem hiding this comment.
Is CI not working as we expect?
Seems so indeed. Running the tests locally on Windows/PS cause them to fail. I'll create a bug for this and take another look.
|
I merged this for now, we can always debug CI problems later. Thank you. |
einfachIrgendwer0815
added a commit
to einfachIrgendwer0815/bat
that referenced
this pull request
Oct 18, 2024
…ed as a later argument. (sharkdp#2660)" This partially reverts commit e2bf85e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Pand-ppdo not take precedence over--paging=alwaysset in~/.config/bat/config#2128-ppoverride--pagingand vice versa when passed as a later argument. #2330