Clap 3.2 #1048
Clap 3.2 #1048
Conversation
Because that is needed for the new version of clap_complete, and it only updates the patch version, so it should be fine to bump it.
|
Thank you for working on this. On a first glance, the new code looks quite a bit more complicated than what we had before, or am I mistaken? The build process also seems to be more complicated with a new feature flag? |
| @@ -525,6 +552,7 @@ pub fn build_app() -> Command<'static> { | |||
| .short('S') | |||
| .takes_value(true) | |||
| .number_of_values(1) | |||
| .value_parser(SizeFilter::from_string) | |||
There was a problem hiding this comment.
Personally, I'd recommend splitting up the resolving of deprecations and using new features into separate PRs.
This way it doesn't get blocked on discussions around items like
On a first glance, the new code looks quite a bit more complicated than what we had before, or am I mistaken? The build process also seems to be more complicated with a new feature flag?
|
I'm just going to close this, in favor of #1067. I tried making this first, but then though that using the derive api might be better. |
This doesn't replace every deprecated api in clap 3.2, but it does make use of some of the new features in the places where I thought it was most valuable.