Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to nu-ansi-term 0.49 #72

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Conversation

sholderbach
Copy link
Contributor

This release fixes the problem that blocked #68

This PR just keeps the behavior as before and does not yet incorporate
the GNU compatibility focussed changes as worked on in #66

This release fixes the problem that blocked sharkdp#68

This PR just keeps the behavior as before and does not yet incorporate
the GNU compatibility focussed changes as worked on in sharkdp#66
@sharkdp
Copy link
Owner

sharkdp commented Jul 23, 2023

Looks like we need to bump MSRV, which is fine for me:

error: package rustix v0.38.4 cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.62.1

@sholderbach
Copy link
Contributor Author

I can take care of that.

The source of the MSRV increase is apparently the unrelated update from tempfile 3.6.0 to 3.7.0 which went from rustix v0.37.23 -> v0.38.4. So semver "compatible" change in the dev-dependencies.

Due to unrelated update of dev-dependency tempfile from 3.6.0 to 3.7.0
which requires rustix 0.38.4 with increased MSRV of 1.63.0
@sharkdp sharkdp merged commit 76c0971 into sharkdp:master Jul 23, 2023
15 checks passed
@sharkdp
Copy link
Owner

sharkdp commented Jul 23, 2023

Thank you

@sholderbach
Copy link
Contributor Author

Thanks for the quick turnaorund!

Would you mind a new release so nushell can upgrade to the latest nu-ansi-term?

@sholderbach sholderbach deleted the nu-ansi-term-0.49 branch July 24, 2023 08:33
@sharkdp
Copy link
Owner

sharkdp commented Jul 24, 2023

Would you mind a new release so nushell can upgrade to the latest nu-ansi-term?

Done

@sholderbach
Copy link
Contributor Author

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants