Implement icon extraction from windows ico files #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is marked as a Draft as I'm not sure what would be the best way to handle required dependencies.
The idea is to extract a png icon for games that provide only
goggame-*.ico
, a png version would be useful for.desktop
files.Current PR does not introduce any new mandatory dependencies and tries two approaches to extracting the icon:
There are two issues I would like to discuss:
pillow
as mandatory dependency torequirements.txt
, is that acceptable?