Fix issue 367 https://github.com/sharkwouter/minigalaxy/issues/367 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds code to cache cover images to disk It also adds new AssetManager and Asset classes to manage assets like thumbnails and covers. Tests have been added for Asset, some additional mocking needs to be added for network tests.
|
Fixed up the unit tests failing and added a comment about the reason. Thanks again for your time. Related, there's a single unit test that fails when run alone: python -m unittest tests/test_ui_window.py It's missing some mocks that get setup in earlier unit tests and not deleted. I can add an issue for it and look at it later if you want. |
|
Som the problem this PR addresses has been solved now, but the asset manager is an interesting idea. I'm going to try to remove a lot of business logic from the GameTile, Library and Window classes, after that I'll re-evaluate the ideas in this PR. |
|
No problem. Thanks again for the great application and have a good week. Feel free to close this PR if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code to cache cover images to disk, fixiing issue #367.
It also adds new AssetManager and Asset classes to manage assets like
thumbnails and covers. This simplifies the codebase some and separates interfaces between layers somewhat.
Tests have been added for Asset, some additional mocking needs to be added for network tests to test AssetManager.
I want to add tests to this to test the full AssetManager class, but I need to mock out the requests library. There are a ton of options for doing this, including several Python libraries. Before I add another library, I'd appreciate input on your preferred method.
Currently, this commit is failing flake8 for window.py I think that needs to be fixed in another branch.
This can be integrated into the other PR once that is cleaned up.
Thank you again for your time looking at this and the project.
Thanks,
Josh