-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow customizing ramdisk options #180
Conversation
Oddly enough, I'm unable to get tests to run successfully locally. |
Yeah, I wonder what's up with that. The CI seems to pass. |
It's looking like a problem with puppeteer. Tried to reinstall it and ran into a wall:
|
@shellscape That's an interesting one. I wonder if it's something temporary. I guess we could try to look into updating puppeteer though based on the error, it sounds like it had downloaded it already but failed to detect that. |
Turned out that it was due to a buggy version of Node 10. Used the latest stable of v10 and it worked. Still need to refactor these tests. After updating Ava we have a bunch of dangling handles. |
@shellscape Oh, wow. That's surprising. |
is that only me or we are the ones that find bugs on node versions? LOL |
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
This PR allows you to customize
ramdisk
options by letting the user pass an object containing the options to theramdisk
field.I came by this requirement in a project where the development output doesn't fit the default ramdisk (it's a big build!).