Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow customizing ramdisk options #180

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

bebraw
Copy link
Collaborator

@bebraw bebraw commented Jul 21, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

If yes, please describe the breakage.

Please Describe Your Changes

This PR allows you to customize ramdisk options by letting the user pass an object containing the options to the ramdisk field.

I came by this requirement in a project where the development output doesn't fit the default ramdisk (it's a big build!).

@bebraw bebraw requested a review from shellscape July 21, 2020 14:51
lib/plugins/ramdisk.js Outdated Show resolved Hide resolved
@shellscape shellscape merged commit fa17f8c into shellscape:master Aug 4, 2020
@shellscape
Copy link
Owner

Oddly enough, I'm unable to get tests to run successfully locally.

@bebraw
Copy link
Collaborator Author

bebraw commented Aug 4, 2020

Oddly enough, I'm unable to get tests to run successfully locally.

Yeah, I wonder what's up with that. The CI seems to pass.

@shellscape
Copy link
Owner

It's looking like a problem with puppeteer. Tried to reinstall it and ran into a wall:

Downloading Chromium r782078 - 128 Mb [====================] 100% 0.0s 
ERROR: Failed to set up Chromium r782078! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.
{ [Error: EEXIST: file already exists, mkdir '/.../node_modules/puppeteer/.local-chromium/mac-782078']

@bebraw
Copy link
Collaborator Author

bebraw commented Aug 5, 2020

@shellscape That's an interesting one. I wonder if it's something temporary. I guess we could try to look into updating puppeteer though based on the error, it sounds like it had downloaded it already but failed to detect that.

@shellscape
Copy link
Owner

Turned out that it was due to a buggy version of Node 10. Used the latest stable of v10 and it worked. Still need to refactor these tests. After updating Ava we have a bunch of dangling handles.

@bebraw
Copy link
Collaborator Author

bebraw commented Aug 6, 2020

@shellscape Oh, wow. That's surprising.

@matheus1lva
Copy link
Collaborator

is that only me or we are the ones that find bugs on node versions? LOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants