Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added login-/registerTextColor to attributes #6

Merged
merged 1 commit into from
Jan 27, 2016
Merged

added login-/registerTextColor to attributes #6

merged 1 commit into from
Jan 27, 2016

Conversation

StefMa
Copy link
Contributor

@StefMa StefMa commented Jan 27, 2016

I think the title says all 😆

@shem8
Copy link
Owner

shem8 commented Jan 27, 2016

The register color is also in the drawable background
Some colors are also used as tint color and as selectors (in styles), how we gonna set those if we change the color to be an arrtibute?

@StefMa
Copy link
Contributor Author

StefMa commented Jan 27, 2016

This PR have nothing to do with #5.
These changes are only for the EditText TextColors.

Why?

Because the textColor is default black (because of the style in styles.xml). In your customize example you create a black background. So the black text is displayed on a black background :)

@shem8
Copy link
Owner

shem8 commented Jan 27, 2016

Oh, you're right =)

shem8 pushed a commit that referenced this pull request Jan 27, 2016
added login-/registerTextColor to attributes
@shem8 shem8 merged commit cc1ae5e into shem8:master Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants