fix: await for close

sheremet-va · Dec 30, 2023 · 751f009 · 751f009
1 parent 0e6d76c
commit 751f009
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/vite/src/node/server/hmr.ts b/packages/vite/src/node/server/hmr.ts
@@ -84,10 +84,10 @@ export interface HMRChannel {
   /**
    * Disconnect all clients
    */
-  close(): void
+  close(): void | Promise<void>
 }
 
-export interface HMRBroadcaster extends HMRChannel {
+export interface HMRBroadcaster extends Omit<HMRChannel, 'close'> {
   /**
    * All registered channels. Always has websocket channel.
    */
@@ -96,6 +96,7 @@ export interface HMRBroadcaster extends HMRChannel {
    * Add a new third-party channel.
    */
   addChannel(connection: HMRChannel): HMRBroadcaster
+  close(): Promise<unknown[]>
 }
 
 export function getShortName(file: string, root: string): string {
@@ -703,7 +704,7 @@ export function createHMRBroadcaster(): HMRBroadcaster {
       channels.forEach((channel) => channel.send(...(args as [any])))
     },
     close() {
-      return channels.map((channel) => channel.close())
+      return Promise.all(channels.map((channel) => channel.close()))
     },
   }
   return broadcaster