Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] cs-229-supervised-learning #214

Merged
merged 8 commits into from
Jan 5, 2021
Merged

[ko] cs-229-supervised-learning #214

merged 8 commits into from
Jan 5, 2021

Conversation

kimdanny
Copy link
Contributor

I've just made a new PR to work on top of rickie's translation.

@kimdanny kimdanny changed the title taking over @rickiepark 's previous work on a new PR [ko] cs-229-supervised-learning -taking over @rickiepark 's previous work on a new PR Nov 14, 2020
@shervinea shervinea mentioned this pull request Nov 15, 2020
Closed
@shervinea shervinea changed the title [ko] cs-229-supervised-learning -taking over @rickiepark 's previous work on a new PR [ko] cs-229-supervised-learning Nov 15, 2020
@shervinea shervinea added the in progress Work in progress label Nov 15, 2020
@shervinea
Copy link
Owner

Thank you @kimdanny for building on top of @rickiepark's work! Marking the pull request as work in progress.

@kimdanny
Copy link
Contributor Author

Just PR'ed the rest of the translations! @shervinea

@shervinea
Copy link
Owner

Thanks @kimdanny for all your work! Switching the PR to review mode. Please feel free to invite anyone you believe could take a look at your translation.

@shervinea shervinea added reviewer wanted Looking for a reviewer and removed in progress Work in progress labels Dec 27, 2020
changh95
changh95 approved these changes Dec 28, 2020
View reviewed changes
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
rickiepark
rickiepark reviewed Dec 28, 2020
View reviewed changes
Copy link
Contributor

@rickiepark rickiepark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kimdanny,
Thank you for this pr.
Please check my suggestions. :)

ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
ko/cs-229-supervised-learning.md Outdated Show resolved Hide resolved
@kimdanny
Copy link
Contributor Author

kimdanny commented Dec 29, 2020 •
edited
Loading

Thanks to @rickiepark 's wonderful and very detailed review, I could fix quite a few mistakes of mine. His review definitely shows his professionalism.
I believe that this work has now reached a launch-able quality @shervinea :)

@rickiepark
Copy link
Contributor

Thank you @kimdanny
LGTM! :)

@shervinea
Copy link
Owner

Thank you both @rickiepark and @kimdanny for your amazing work!

@shervinea shervinea merged commit bca2eaa into shervinea:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickiepark rickiepark rickiepark left review comments

@changh95 changh95 changh95 approved these changes

Assignees
No one assigned
Labels
reviewer wanted Looking for a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimdanny @shervinea @rickiepark @changh95