Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some QR codes not read properly in the web QR scanner #134

Closed
shesek opened this issue Dec 25, 2019 · 5 comments
Closed

Some QR codes not read properly in the web QR scanner #134

shesek opened this issue Dec 25, 2019 · 5 comments

Comments

@shesek
Copy link
Owner

shesek commented Dec 25, 2019

Reported by @sumBTC at #55 (comment).
shesek added a commit that referenced this issue Dec 25, 2019
@shesek
Handle instascan providing an array as the QR contents
b3c9345 
This does not normally happen, but some QRs appear to result in an
array with two elements, the first being the actual contents and
the second set to `null`. Possibly a bug in the instascan library?

Refs #134
@shesek
Copy link
Owner Author

shesek commented Dec 25, 2019

@sumBTC I believe b3c9345 should resolve this, are you able to test this from master before I make a new release?

@shesek shesek mentioned this issue Dec 25, 2019
Closed
@ghost
Copy link

ghost commented Dec 25, 2019

@shesek I would like to test it. I have downloaded the latest master via git clone (or later git pull) but how do I install the master? I keep seeing the old install (sorry for this basic question but it has been bugging me for some time)

@shesek
Copy link
Owner Author

shesek commented Dec 25, 2019 •
edited
Loading

If you cloned/pulled now, you should already by on the latest version of the master branch.

You'll need to npm install inside the directory you cloned, then npm start -- --ln-path ~/.lightning/bitcoin to start the development server daemon (note the extra --, they need to be there).

The development server does on-the-fly compilation and is therefore slower and takes up more resources. If you want to use it as your actual wallet and not just for testing, you can also pre-compile it with npm run dist:npm then start it with ./dist/cli.js <args>.

@ghost
Copy link

ghost commented Dec 25, 2019

@shesek Well good I asked :-)

Yes, the QR scanner worked perfectly now! Wow, pretty amazing how fast you solved that. Thanks a lot.

At least spark-wallet works over tls in a browser and can scan QR codes! Happy Christmas, family deserves some attention now haha

@shesek
Copy link
Owner Author

shesek commented Dec 25, 2019

Happy Christmas!

@shesek shesek closed this as completed Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shesek