change bolt12_unsigned to bolt12 #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nel balance display
|
This is really valuable work! CL 23.05 support is huge. I'm not sure if shesek still intends to maintain this repo, would you be open to maintaining a fork? |
|
Thanks for the acknowledgment but I'm not qualified enough for such a task. It was already hard to find the stuff that had to be changed to get spark-wallet working again especially with "allow-deprecated-apis=false" in config so it will keep working in the (near) future. Nevertheless a fully working spark-wallet for usd can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking change in Core Lightning is here. The variable
bolt12_unsignedwas removed while spark-wallet still expects it. So we have to changebolt12_unsignedintobolt12. Because of this generating a (qr code of a) reusable offer in spark-wallet no longer worked.