[Benchmark] New benchmarking tool with gnuplot(2) #168
Conversation
| @@ -5,6 +5,7 @@ clean : | |||
| +"$(MAKE)" --directory=./gencoef clean | |||
| +"$(MAKE)" --directory=./libm clean | |||
| +"$(MAKE)" --directory=./libm-tester clean | |||
| +"$(MAKE)" --directory=./libm-benchmarks clean | |||
There was a problem hiding this comment.
Remove, we don't care about makefiles.
src/libm-benchmarks/Makefile
Outdated
| @@ -0,0 +1,6 @@ | |||
| .PHONY: clean | |||
There was a problem hiding this comment.
Remove, we don't care about makefiles.
| @@ -0,0 +1,110 @@ | |||
| BENCHSLEEF := $(shell command -v benchsleef 2> /dev/null) | |||
There was a problem hiding this comment.
Did you even read the comment at the top of this page?
There was a problem hiding this comment.
Yes, I still think we shouldn't have makefiles down inside the tree of src.
If you really want to keep the makefiles, then I think you should move all this benchmarks and relative scripts at the same level of src, in a folder like svml-benchmarking, and keep it as a sort of independent project inside SLEEF.
There was a problem hiding this comment.
Originally, the whole directory including all the C codes were like an independent project.
I think that is easier to understand.
Why do you think C codes have to be compiled by cmake?
| @@ -0,0 +1,153 @@ | |||
| // Copyright Naoki Shibata 2010 - 2017. | |||
There was a problem hiding this comment.
This looks like a benchmark, why is it in the plot folder? The plot-scripts folder should just contain the scripts that are used to make the plots.
| @@ -0,0 +1,137 @@ | |||
| // Copyright Naoki Shibata 2010 - 2017. | |||
There was a problem hiding this comment.
Another benchmark that should sit one folder up?
| @@ -0,0 +1,140 @@ | |||
| // Copyright Naoki Shibata 2010 - 2017. | |||
There was a problem hiding this comment.
Same, benchmark code, not script for plotting.
| @@ -0,0 +1,137 @@ | |||
| // Copyright Naoki Shibata 2010 - 2017. | |||
There was a problem hiding this comment.
Same, benchmark, not script.
|
|
||
| if [ -f counter.txt ] | ||
| then | ||
| counter=`cat counter.txt` |
There was a problem hiding this comment.
Does counter need any particular syntax?
| @@ -0,0 +1,17 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
It is not clear how to use this script. Who is invoking the java tool?
Agree. Please move it at the same level of
I don't think it anymore. Please remove any cmake configuration related to these benchmark. |
This is a rebased branch of #98.
This patch replaces the old benchmarking tool with a new tool with gnuplot.
With this new tool, the graph showing execution time can be automatically drawn.
It is now easy to see the difference between different library versions or compilers.
This tool is used to draw the graphs on sleef.org web site.
This patch implements the tool described in #9.
A makefile is used In this patch, and there are a few reasons.