Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SLEEF_BUILD_SCALAR_LIB lost function #515

Merged

Conversation

xuhancn
Copy link
Contributor

@xuhancn xuhancn commented Feb 12, 2024

Fix "SLEEF_BUILD_SCALAR_LIB" lost function to control build sleefscalar lib.

Status Control Build Control Install
Current Code No Yes
This PR Yes Yes

Original code: SLEEF_BUILD_SCALAR_LIB only control whether install scalar_lib, it would always build scalar_lib.
My PR: SLEEF_BUILD_SCALAR_LIB control both whether build and install scalar_lib.

@xuhancn xuhancn force-pushed the fix_SLEEF_BUILD_SCALAR_LIB_lost_function branch from fb76b12 to 49166f9 Compare February 12, 2024 18:08
@xuhancn xuhancn changed the title Fix sleef b UI ld scalar lib lost function Fix SLEEF_BUILD_SCALAR_LIB lost function Feb 12, 2024
@xuhancn xuhancn marked this pull request as ready for review February 12, 2024 18:09
@blapie
Copy link
Collaborator

blapie commented Mar 4, 2024

Hi! Could you please give a bit of context?

What do you mean by lost function? Do you mean that library is build but not installed?

I can see a benefit in choosing to build scalar libs or not, especially if they are not installed after all.

Just a quick reminder. In the original design, scalar routines are not meant to be used but rather here as a reference for vector implementations. So it is recommended not to use them when performance matters.

@xuhancn
Copy link
Contributor Author

xuhancn commented Mar 6, 2024

Hi! Could you please give a bit of context?

What do you mean by lost function? Do you mean that library is build but not installed?

I can see a benefit in choosing to build scalar libs or not, especially if they are not installed after all.

Just a quick reminder. In the original design, scalar routines are not meant to be used but rather here as a reference for vector implementations. So it is recommended not to use them when performance matters.

Q: What do you mean by lost function? Do you mean that library is build but not installed?
A: I think SLEEF_BUILD_SCALAR_LIB should like other switch, both control build and install its library. lost function means lost control to build.

Original code: SLEEF_BUILD_SCALAR_LIB only control whether install scalar_lib, it would always build scalar_lib.
My PR: SLEEF_BUILD_SCALAR_LIB control both whether build and install scalar_lib.

update to description also.

@blapie blapie merged commit 82a3780 into shibatch:master Mar 13, 2024
31 checks passed
@xuhancn xuhancn deleted the fix_SLEEF_BUILD_SCALAR_LIB_lost_function branch March 15, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants