Reconcile RVV mask types. #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the vmask types for single-precision and double-precision interfaces compatible, so that we have fewer divergent functions. Keep the vopmask types incompatible, because the underlying vbool*_t types still encode some underlying assumptions about the number of lanes involved. Make the still-incompatible function names distinct between SP and DP, and then reconcile these with the preprocessor at the end of the file so that the caller still sees the expected operations. This will help when it comes to generating inline headers in a future revision.
|
This contains a portion of #503, and fits underneath that PR, so that each can be reviewed in isolation. |
This was referenced Feb 16, 2024
luhenry
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
And all tests pass on CI: https://github.com/rivosinc/sleef/actions/runs/7925708693
cc @ericlove @GlassOfWhiskey for review
|
Hi @luhenry, I want to look into these this week. Happy to see that it is all coming together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the vmask types for single-precision and double-precision interfaces compatible, so that we have fewer divergent functions.
Keep the vopmask types incompatible, because the underlying vbool*_t types still encode some underlying assumptions about the number of lanes involved.
Make the still-incompatible function names distinct between SP and DP, and then reconcile these with the preprocessor at the end of the file so that the caller still sees the expected operations. This will help when it comes to generating inline headers in a future revision.