Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure.cmake: improve RVV1 check #602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Nov 5, 2024

  1. Configure.cmake: improve and unify RISC-V vector extension checks

    To test for the RISC-V vector extension (RVV), we currently run two
    small programs -- one for each value of LMUL=1,2 -- that use some
    vector intrinsics from the v0.11.x draft of the intrinsics spec. The
    library itself however needs newer intrinsics than the ones that we
    test for. This can lead to a problem because GCC 13 supports the
    intrinsics that we test for, but not (all of) the ones we intend to
    use. In short, the build can fail with GCC 13:
    
      shibatch#579
    
    This commit changes the detection mechanism. Instead of compiling a
    program that makes use of the intrinsics, we now just check the two
    values, __riscv_v and __riscv_v_intrinsic, to ensure that we have
    version 1.0 of the vector extension and version 0.12 of the
    intrinsics. These should be the stable versions of each.
    
    Note: the "m1" and "m2" checks are now identical because they are both
    covered by the official spec.
    
    Fixes shibatch#579
    orlitzky committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ca5e8a2 View commit details
    Browse the repository at this point in the history